Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8295 Initial Yandex.Cloud monitoring #8296

Merged
merged 4 commits into from
Nov 2, 2020
Merged

#8295 Initial Yandex.Cloud monitoring #8296

merged 4 commits into from
Nov 2, 2020

Conversation

peter-volkov
Copy link
Contributor

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@peter-volkov peter-volkov changed the title #8295 Initial Yandex.Clout monitoring #8295 Initial Yandex.Cloud monitoring Oct 21, 2020
@peter-volkov
Copy link
Contributor Author

@p-zak can you please take another look?

@p-zak
Copy link
Collaborator

p-zak commented Oct 30, 2020

@p-zak can you please take another look?

LGTM!

@peter-volkov
Copy link
Contributor Author

@p-zak thank you. Who can merge the PR?

@p-zak
Copy link
Collaborator

p-zak commented Oct 30, 2020

@p-zak thank you. Who can merge the PR?

Need to wait for @ssoroka or @reimda

@ssoroka
Copy link
Contributor

ssoroka commented Oct 30, 2020 •
edited
Loading

Looking pretty good. I have a few more change requests.

@peter-volkov peter-volkov requested a review from ssoroka October 30, 2020 23:26
ssoroka
ssoroka reviewed Nov 2, 2020
View reviewed changes
Copy link
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've requested a few small edits, and then we can get this merged.

plugins/outputs/yandex_cloud_monitoring/yandex_cloud_monitoring.go Outdated Show resolved Hide resolved
@peter-volkov peter-volkov requested a review from ssoroka November 2, 2020 14:47
@ssoroka
Copy link
Contributor

ssoroka commented Nov 2, 2020

Thanks! Will merge as soon as the tests pass

@ssoroka ssoroka merged commit 38796f0 into influxdata:master Nov 2, 2020
@sjwang90 sjwang90 mentioned this pull request Nov 24, 2020
Closed
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@peter-volkov
influxdata#8295 Initial Yandex.Cloud monitoring (influxdata#8296)
bc0d098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-zak p-zak p-zak left review comments

@ssoroka ssoroka ssoroka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peter-volkov @p-zak @ssoroka