feat: add functionality to get values from redis commands #8196
Conversation
yquansah
force-pushed
the
yq-redis-list
branch
from
36b3f2e to
fd9abf2
Compare
|
Was a little unsure of how exactly to go about editing README |
There was a problem hiding this comment.
Looks good. The only thing I'd say is that this might be better off as a new plugin. Already you're going to have a hard time changing the metric name if you don't like redis_commands. Also not clear how to control which commands go into which metric, which I guess is not possible currently. That said, I'm not necessarily against merging it into the existing plugin.
plugins/inputs/redis/redis.go
Outdated
| # command = ["get", "sample-key"] | ||
| # key = "sample-key-value" | ||
| # type = "string" | ||
|
|
There was a problem hiding this comment.
this looks wrong. Don't you need to specify [[inputs.redis.commands]] ahead of this?
There was a problem hiding this comment.
consider naming "key" field instead.
There was a problem hiding this comment.
changes should be copied into readme.
There was a problem hiding this comment.
This is addressed! Thank you for the catch, let me know if there is anything else needed.
Describe how to use the feature you added. Give examples so people unfamiliar with the feature will be able to understand how to configure it and know what data it will produce. |
Required for all PRs:
This PR is an attempt to pull additional metrics on redis from arbitrary commands. The logic in this PR accounts for types (
string,integer, andfloat), and we could add more types.Issue addressed: https://github.com/influxdata/idpe/issues/8711
Community issue Addressed: #1027