-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increasing the metric buffer #8145
Conversation
plugins/processors/execd/execd.go
Outdated
## Buffer size in bytes for storing metrics received from the process | ||
## The minimum allowed value is 4096 | ||
buffer_size = 65536 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is actually the buffer size used for storing a single metric, not multiple metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure I like that it's configurable. we should just do the right thing. Too many knobs and dials to configure is just confusing.
This could literally be a two line change that works for 100% of people. No configuration options.
What about these values?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
You may run into size issues in other places, but at least this won't be one of them. |
Yes, I understand, but for now we prefer to use an external processor for working with XML - until a built-in parser appears in the telegraf. I tested processing larger documents (10-12 thousand lines), everything is fine with the new buffer. Many thanks for the help! |
plugins/processors/execd/README.md
Outdated
|
||
## Buffer size in bytes for storing metrics received from the process | ||
## The minimum allowed value is 4096 | ||
# buffer_size = 65536 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its the same when execd used as inputs plugin?
Required for all PRs:
Closes #8142
Also related with #8121