Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugins/input/jenkins): add build number field to jenkins_job measurement #8038

Merged
merged 1 commit into from
Dec 10, 2020
Merged

feat(plugins/input/jenkins): add build number field to jenkins_job measurement #8038

merged 1 commit into from
Dec 10, 2020

Conversation

alespour
Copy link
Contributor

This PR adds number field to jenkins_job measurement. It allows eg. to create links to specific builds in dashboards.

Example output (telegraf --config telegraf.conf --input-filter jenkins --test):

2020-08-26T14:42:29Z I! Starting Telegraf 
> jenkins,host=jenkins.bonitoo4influxdata.com,port=8443,source=localhost busy_executors=2i,total_executors=8i 1598452951000000000
...
> jenkins_job,host=jenkins.bonitoo4influxdata.com,name=deploy-tickstack-eprise-partial,port=8443,result=SUCCESS,source=localhost duration=108962i,number=1091i,result_code=0i 1598450671000000000

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@alespour alespour marked this pull request as ready for review August 26, 2020 16:06
@alespour alespour changed the title feat: add build number field to jenkins_job measurement feat(plugins/input/jenkins): add build number field to jenkins_job measurement Aug 26, 2020
@alespour alespour mentioned this pull request Aug 27, 2020
Merged
@sjwang90 sjwang90 added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 28, 2020
@srebhan srebhan self-assigned this Dec 3, 2020
srebhan
srebhan approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 3, 2020
@ssoroka ssoroka merged commit d3031a4 into influxdata:master Dec 10, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@alespour
feat: add build number field to jenkins_job measurement (influxdata#8038
db78bcd 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@ssoroka ssoroka ssoroka approved these changes

Assignees

@ssoroka ssoroka

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alespour @ssoroka @srebhan @sjwang90