-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http_response: status_code match #8032
Conversation
The CI has failed but it's seems to be an error from another plugin, not sure I've an impact on this |
@reimda They're a way to re-triggrer circleci without commit? |
I think only admins can so triggered them. Looks like they passed |
would it make more sense to instead just record the status code, instead of a binary match/no-match? |
The status code is already record under |
(cherry picked from commit 527a11a)
Required for all PRs:
I've added the possibility to match on the status code instead of only the response body, can be useful if your service return a 204.
I'm not fully satisfied because actually we can only check the body OR the status code (not both). Technically isn't difficult to be able to do both, but that require some decisions about the
result
value, if only one of these fail the value is pretty obvious but in case both check fail, do we need to create another value (response_mismatch
?) or set the field toresponse_status_code_mismatch
orresponse_string_mismatch
Thanks!