Support utf-16 in file and tail inputs #7792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
added
the
feat
ssoroka
approved these changes
Jul 7, 2020
| if recordFields[p.MeasurementColumn] != nil && recordFields[p.MeasurementColumn] != "" { | ||
| measurementName = fmt.Sprintf("%v", recordFields[p.MeasurementColumn]) | ||
| if p.MeasurementColumn != "" { | ||
| if recordFields[p.MeasurementColumn] != nil && recordFields[p.MeasurementColumn] != "" { |
There was a problem hiding this comment.
how can you compare this without a type assertion?
There was a problem hiding this comment.
I wasn't sure about this existing code, so I added some tests, seems to be working. The conditional I added fixes a bug where the measurement name could be set to the value of an empty string named column.
Found this in the spec:
Interface values are comparable. Two interface values are equal if they have identical dynamic types and equal dynamic values or if both have value nil.
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7299
closes #6876
Also see changes on influxdata/tail: influxdata/tail@master...influxdata:open-reader-func
Required for all PRs: