Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sql Server iputn - removed trailing backslash trim #7700

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Sql Server iputn - removed trailing backslash trim #7700

merged 1 commit into from
Jun 17, 2020

Conversation

Trovalo
Copy link
Collaborator

@Trovalo Trovalo commented Jun 17, 2020

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

This PR just removes the removal of trailing backslashes from the query itself.
Now that #7558 has been closed, this kind of logic is not needed inside the query itself.

@Trovalo
Copy link
Collaborator Author

Trovalo commented Jun 17, 2020

@danielnelson you didn't give me the time to apply this in the main branch few days ago so I opened this PR

@danielnelson
Copy link
Contributor

Sorry, I got mixed up on the ordering of the PRs last week, thanks for following up with this.

@danielnelson danielnelson merged commit 5b84d3b into influxdata:master Jun 17, 2020
@danielnelson danielnelson added this to the 1.15.0 milestone Jun 17, 2020
@danielnelson danielnelson added area/sqlserver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jun 17, 2020
@Trovalo Trovalo deleted the SqlServer_TrimTest branch June 18, 2020 13:56
rhajek pushed a commit to bonitoo-io/telegraf that referenced this pull request Jul 13, 2020
@Trovalo @rhajek
Remove trailing backslash management in sqlserver input (influxdata#7700
30be75b 
)

Backslash removal on tags is performed by the influx serializer now.
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@Trovalo
Remove trailing backslash management in sqlserver input (influxdata#7700
cac4923 
)

Backslash removal on tags is performed by the influx serializer now.
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@Trovalo
Remove trailing backslash management in sqlserver input (influxdata#7700
27a16c8 
)

Backslash removal on tags is performed by the influx serializer now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/sqlserver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Trovalo @danielnelson