consul input - allow flags to ignore very high cardinality metrics #7643
Conversation
plugins/inputs/consul/README.md
Outdated
| ## Disable gathering check id from Consul on health checks | ||
| # This is useful in dynamic environments, where check_id is generated, | ||
| # where most check_id's are some uuid-ish name with low meaning. | ||
| # disable_check_id = false |
There was a problem hiding this comment.
Instead of this option, I suggest using tagexclude = ["check_id"]. This is a general solution that can be used on any plugin.
There was a problem hiding this comment.
Sure, do you mind if I leave a note in the readme for this suggesting that for our (and likely others) scenario?
plugins/inputs/consul/README.md
Outdated
| ## Disable gathering tags from Consul on health checks | ||
| # This is very useful on large clusters with a lot of services and tags. | ||
| # This alleviates the situation of this telegraf running on multiple servers | ||
| # for a holistic point of view, and there are thousands of checks with 10+ tags. | ||
| # disable_tags = false |
There was a problem hiding this comment.
Do you think you could update this to match the method I suggested here: #7387 (comment)
You can set this up fairly easily by using filters.NewIncludeExcludeFilter.
There was a problem hiding this comment.
Sure! So we're on on the same page, to replicate the behaviour I want, I'd need to set:
[[inputs.consul]]
... # config
service_tag_include = []
service_tag_exclude = ["*"]
The behaviour I'm expecting would be for this is for the input to pass along service_id, node, and check_id, then check_id can be excluded with tagexclude = ["check_id"] to replicate what I've tried here.
Is my understanding correct?
There was a problem hiding this comment.
Yes, that's right. To clarify the behavior of the service_tag_include and service_tag_exclude options, they would match the entire ServiceTag string, before any splitting, but would only affect these tags.
danielnelson
added
the
feat
|
@danielnelson can you re-review? I mostly based this off of what was in ECS and the Docker inputs. I also moved the client + filter initialization into it's own function called by Gather, to allow the test suite to call the same function to initialize the filters. |
|
@chuckyz can you please rebase this PR and resolve the merge conflicts? |
|
I'll close this due to inactivity. If you are still interested in getting this merged, please reopen this PR or drop me a note. |
Required for all PRs: