Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to github.com/shirou/gopsutil v2.20.5 #7641

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

danielnelson
Copy link
Contributor

@danielnelson danielnelson commented Jun 5, 2020

closes #7018
closes #6807

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added this to the 1.15.0 milestone Jun 5, 2020
@danielnelson danielnelson requested a review from ssoroka June 5, 2020 22:20
Copy link
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but test failures. plugins/inputs/procstat/native_finder_windows.go:63:104: undefined: process.Win32_Process

@danielnelson
Copy link
Contributor Author

Here is the before and after for the native finder. CPU is down on Windows but allocations are up.

$ go test -short ./plugins/inputs/procstat/... -bench=. -benchmem
goos: windows
goarch: amd64
pkg: github.com/influxdata/telegraf/plugins/inputs/procstat
BenchmarkPattern-16                   18          68615033 ns/op           27202 B/op        290 allocs/op
BenchmarkFullPattern-16               31          34742177 ns/op           10256 B/op        101 allocs/op
PASS
ok      github.com/influxdata/telegraf/plugins/inputs/procstat  3.443s

dbn@LOKI C:\Users\dbn\go\src\github.com\influxdata\telegraf
$ go test -short ./plugins/inputs/procstat/... -bench=. -benchmem
goos: windows
goarch: amd64
pkg: github.com/influxdata/telegraf/plugins/inputs/procstat
BenchmarkPattern-16                   18          62448017 ns/op           24564 B/op        281 allocs/op
BenchmarkFullPattern-16              444           2551948 ns/op           92771 B/op       1105 allocs/op
PASS
ok      github.com/influxdata/telegraf/plugins/inputs/procstat  3.514s

This may fix #6807 and the removes the need for #7129

@danielnelson danielnelson requested a review from ssoroka June 8, 2020 16:44
@danielnelson danielnelson merged commit 894841a into master Jun 8, 2020
@danielnelson danielnelson deleted the gopsutil-2.20.5 branch June 8, 2020 20:26
rhajek pushed a commit to bonitoo-io/telegraf that referenced this pull request Jul 13, 2020
haojhcwa pushed a commit to haojhcwa/telegraf that referenced this pull request Aug 30, 2020
yimuniao added a commit to aws/telegraf that referenced this pull request Aug 30, 2020
Update to github.com/shirou/gopsutil v2.20.5 (influxdata#7641)
haojhcwa added a commit to haojhcwa/telegraf that referenced this pull request Aug 30, 2020
This reverts commit 302645d.
Use our own fix by forking wmi library
haojhcwa added a commit to aws/telegraf that referenced this pull request Aug 30, 2020
This reverts commit 302645d.
Use our own fix by forking wmi library
haojhcwa pushed a commit to haojhcwa/telegraf that referenced this pull request Aug 31, 2020
haojhcwa pushed a commit to aws/telegraf that referenced this pull request Sep 2, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
rmfitzpatrick pushed a commit to signalfx/telegraf that referenced this pull request Dec 11, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect time slip and adjust uptime in the system input Memory Leak with procstat
2 participants