Ignore fields with NaN or Inf floats in the JSON serializer #7426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
added
fix
reimda
approved these changes
Apr 28, 2020
Comment on lines
+54
to
+58
| tags := make(map[string]string, len(metric.TagList())) | ||
| for _, tag := range metric.TagList() { | ||
| tags[tag.Key] = tag.Value | ||
| } | ||
| m["tags"] = tags |
There was a problem hiding this comment.
Just curious why this is better than before. Is it better not to refer to the same map? Kind of a deep copy but what's the benefit?
There was a problem hiding this comment.
I'd like to remove the metric.Tags() and Fields() method the interface, they are marked as deprecated now, so I just took the liberty to do stop using them here. We don't use a map in the metric implementation anymore, since a list is more memory and GC friendly in most cases. Both of these functions make a new map and are basically equivalent to what I've done here.
danielnelson
added a commit
that referenced
this pull request
Apr 28, 2020
(cherry picked from commit c4e9f72)
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change it is possible to have a metric with no encodeable fields. I debated having the serializer skip the metric and potentially return an empty buffer, this would be similar to what the influx serializer does, but decided against it in this case. With line protocol, it isn't possible to write a line without fields, but with JSON it is still possible to write the remaining data and guarantees that something will be written. Since this data format is often used for debugging I think this will be the best behavior.
closes #7388
Required for all PRs: