Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7344: Add percentiles to the ping plugin #7345

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Fix #7344: Add percentiles to the ping plugin #7345

merged 1 commit into from
Dec 9, 2020

Conversation

fhriley
Copy link
Contributor

@fhriley fhriley commented Apr 16, 2020

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@fhriley
Copy link
Contributor Author

fhriley commented Jun 8, 2020

Can someone review this? It's much better than average and standard deviation: https://imgur.com/a/4gQl9bd

@sjwang90 sjwang90 added area/ping feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Nov 23, 2020
@srebhan srebhan self-assigned this Nov 30, 2020
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 30, 2020
@zak-pawel
Copy link
Collaborator

@fhriley Can you rebase your code? You still aiming go 1.12 and 1.13 in CI - nowadays 1.14 and 1.15 versions are tested (rebasing automatically solves this).

@srebhan srebhan removed the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 30, 2020
@fhriley
Copy link
Contributor Author

fhriley commented Dec 1, 2020

@zak-pawel Done.

@zak-pawel
Copy link
Collaborator

@srebhan you review this earlier. What do you think?

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 2, 2020
@srebhan
Copy link
Member

srebhan commented Dec 2, 2020

I think we are good to go.

@reimda
Copy link
Contributor

reimda commented Dec 8, 2020

There was some work done about a year ago to add a T-Digest aggregator to telegraf. It would accurately estimate percentiles and work with data from any source, not just ping. The PR hasn't had much attention for a while. Are any of you interested in picking it up?
#6440
#6887

@reimda reimda closed this Dec 8, 2020
@reimda reimda reopened this Dec 8, 2020
@reimda reimda merged commit 97de398 into influxdata:master Dec 9, 2020
@sjwang90 sjwang90 mentioned this pull request Aug 30, 2021
Closed
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@fhriley
Add percentiles to the ping plugin (influxdata#7345)
6b107ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@reimda reimda reimda approved these changes

Assignees

@srebhan srebhan

Labels
area/ping feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fhriley @zak-pawel @srebhan @reimda @sjwang90