Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for explicitly including queries in sqlserver input plugin. #7150

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

HarshitOnGitHub
Copy link
Contributor

Fixes: #6979.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson
Copy link
Contributor

Try using NewIncludeExcludeFilter, we use this in other plugins and it should give the expected behavior.

@danielnelson danielnelson added area/sqlserver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Mar 10, 2020
@HarshitOnGitHub
Copy link
Contributor Author

Yeah makes sense, updated! :)

@HarshitOnGitHub
Copy link
Contributor Author

@danielnelson Further, can you point me to some small issues that I can try my hands on? :)

@danielnelson danielnelson added this to the 1.14.0 milestone Mar 13, 2020
@danielnelson danielnelson merged commit a612a4d into influxdata:master Mar 16, 2020
@danielnelson
Copy link
Contributor

Thanks for the offer to help. The best issues to look at are the ones with the ready label. Ignore any that have an assignee, the rest are available but add a comment before you get in too deep so others will know you are looking into it. You can also check issues with the bug label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sqlserver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlserver input exclude_query config option may be confusing
2 participants