-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stackdriver plugins to reflect new product naming #7098
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to rename the plugins and directories too? It looks like they've almost completely rebranded to Google Cloud Monitoring.
It looks like the agent binaries are still named stackdriver so maybe it's not a big deal to leave that brand in telegraf?
https://cloud.google.com/monitoring/agent/install-agent
plugins/inputs/stackdriver/README.md
Outdated
@@ -1,6 +1,7 @@ | |||
# Stackdriver Input Plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heading should be "Google Cloud Monitoring Input Plugin"
@@ -1,7 +1,11 @@ | |||
# Stackdriver Output Plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heading should be "Google Cloud Monitoring Output Plugin"
It's possible we will want to add a plugin alias in the future, similar to with http_listener/influxdb_listener. We could name it |
Updated the plugin readme titles to, for example, |
"Google Cloud Monitoring Input Plugin" filter: "metric.type = "compute.googleapis.com/instance/cpu/usage_time"" AND "metric.labels.instance_name = "demo-instance-1"" ERROR 2021-09-17T12:43:11Z E! [inputs.stackdriver] Failed iterating time series responses: "name:"projects/cfs-practice" filter:"metric.type = \"compute.googleapis.com/quota/subnet_ranges_per_vpc_network/exceeded\" AND resource.labels. = \"\" AND metric.labels. = \"\"" interval:{end_time:{seconds:1631882284} start_time:{seconds:1631882224}}": rpc error: code = InvalidArgument desc = Field filter had an invalid value of "metric.type = "compute.googleapis.com/quota/subnet_ranges_per_vpc_network/exceeded" AND resource.labels. = "" AND metric.labels. = """: Could not parse filter "metric.type = "compute.googleapis.com/quota/subnet_ranges_per_vpc_network/exceeded" AND resource.labels. = "" AND metric.labels. = """; syntax error at line 1, column 104, token ' '; |
Required for all PRs: