Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stackdriver plugins to reflect new product naming #7098

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

danielnelson
Copy link
Contributor

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added the docs Issues related to Telegraf documentation and configuration descriptions label Mar 2, 2020
@danielnelson danielnelson added this to the 1.14.0 milestone Mar 2, 2020
@danielnelson danielnelson requested a review from reimda March 2, 2020 20:36
Copy link
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to rename the plugins and directories too? It looks like they've almost completely rebranded to Google Cloud Monitoring.

It looks like the agent binaries are still named stackdriver so maybe it's not a big deal to leave that brand in telegraf?
https://cloud.google.com/monitoring/agent/install-agent

@@ -1,6 +1,7 @@
# Stackdriver Input Plugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heading should be "Google Cloud Monitoring Input Plugin"

@@ -1,7 +1,11 @@
# Stackdriver Output Plugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heading should be "Google Cloud Monitoring Output Plugin"

@danielnelson
Copy link
Contributor Author

It's possible we will want to add a plugin alias in the future, similar to with http_listener/influxdb_listener. We could name it cloud_monitoring to match cloud_pubsub. For now though, I think we should leave it primarily as stackdriver since I think this is the name with the most recognition.

@danielnelson
Copy link
Contributor Author

Updated the plugin readme titles to, for example, Stackdriver Google Cloud Monitoring Input Plugin.

@danielnelson danielnelson merged commit 7b03a6f into master Mar 5, 2020
@danielnelson danielnelson deleted the stackdriver-rename branch March 5, 2020 18:36
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
veorlo pushed a commit to GlobalNOC/telegraf that referenced this pull request May 4, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@uday1984
Copy link

"Google Cloud Monitoring Input Plugin"
Can you share the definition to be define on the telegraf.conf file for the metric label and resource label
I defined the conf file as below and verifed the data is appearing in GoogleCloudPlafform. However telegraf is not able to read it.

filter: "metric.type = "compute.googleapis.com/instance/cpu/usage_time"" AND "metric.labels.instance_name = "demo-instance-1""

ERROR

2021-09-17T12:43:11Z E! [inputs.stackdriver] Failed iterating time series responses: "name:"projects/cfs-practice" filter:"metric.type = \"compute.googleapis.com/quota/subnet_ranges_per_vpc_network/exceeded\" AND resource.labels. = \"\" AND metric.labels. = \"\"" interval:{end_time:{seconds:1631882284} start_time:{seconds:1631882224}}": rpc error: code = InvalidArgument desc = Field filter had an invalid value of "metric.type = "compute.googleapis.com/quota/subnet_ranges_per_vpc_network/exceeded" AND resource.labels. = "" AND metric.labels. = """: Could not parse filter "metric.type = "compute.googleapis.com/quota/subnet_ranges_per_vpc_network/exceeded" AND resource.labels. = "" AND metric.labels. = """; syntax error at line 1, column 104, token ' ';

arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues related to Telegraf documentation and configuration descriptions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants