Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror influxdb api for large payloads in influx_listener input #6185

Closed
wants to merge 1 commit into from

Conversation

glinton
Copy link
Contributor

@glinton glinton commented Jul 30, 2019

Addresses comments in #2280

An attempt was made to add a content-length header to the influxdb output, but it was decided that would cost more than it was worth (read the body to count bytes, then allocate a new reader to use in the request)

@glinton glinton added this to the 1.12.0 milestone Jul 30, 2019
@glinton glinton added the fix pr to fix corresponding bug label Jul 30, 2019
@danielnelson
Copy link
Contributor

danielnelson commented Jul 30, 2019

The old code is too tricky, I don't feel comfortable that it works. We also do a bunch of work so that we can apply a line length limit, a feature that InfluxDB doesn't even appear to have.

Let's remove the ability to limit lines, accepting the option but warning when it is set, and only retain max body limit. This will allow us to pass the full body into the parser and we can use much simpler processing.

This will be needed anyway to solve #6124.

@glinton
Copy link
Contributor Author

glinton commented Aug 5, 2019

Closing in favor of http_listener rewrite referred to here

@glinton glinton closed this Aug 5, 2019
@sspaink sspaink deleted the bugfix/2280 branch October 19, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants