Aggregate multiple Stackdriver TimeSeries in requests #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
added
the
feat
nicbaz
force-pushed
the
5404-stackdriver-aggregate-requests
branch
2 times, most recently
from
db55582 to
cfbaa94
Compare
|
hello @danielnelson, Referring to #5404 what are your thoughts on this implementation? |
nicbaz
force-pushed
the
5404-stackdriver-aggregate-requests
branch
from
cfbaa94 to
db3c13a
Compare
|
@danielnelson fixed 👍 |
|
@Legogris I should have checked this already, but I don't have you listed as having signed our CLA. Could you fill it out, if you already did it once could you do it again as something must have gone wrong on our end. |
@danielnelson Signed (again, I think)! 👍 |
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at #5404. This is not yet perfect, as it just does an iteration over the metrics/fields, adding TimeSeries until adding the next one would mean a duplicate, in which case it sends off the batch so far and then proceeds with a new request.
This should still be an improvement over the current situation (it is not yet properly tested in practice, though)