Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw counters for MongoDB metrics #5264

Merged
merged 3 commits into from
Jan 9, 2019

Conversation

bozaro
Copy link
Contributor

@bozaro bozaro commented Jan 8, 2019

closes #3121

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Unfortunately MongoDB plugin convert counter metrics to gauge. To eliminate this omission this PR adds raw counter MongoDB metrics for per second gauge metrics.

For example: add repl_updates_cnt counter for repl_updates_per_sec gauge metric.

Copy link
Contributor

@danielnelson danielnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bozaro, this has been long wanted. I just have one comment on naming, I'd like eventually to drop the _per_sec metrics and so would like to emphasize these new fields more.

plugins/inputs/mongodb/mongodb_data.go Outdated Show resolved Hide resolved
@danielnelson danielnelson added this to the 1.10.0 milestone Jan 8, 2019
@danielnelson danielnelson added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/mongodb labels Jan 8, 2019
@danielnelson danielnelson merged commit 4b3580c into influxdata:master Jan 9, 2019
@bozaro bozaro deleted the mongodb-counters branch January 10, 2019 06:04
@bozaro
Copy link
Contributor Author

bozaro commented Jan 10, 2019

Thanks a lot!

trevorwhitney pushed a commit to trevorwhitney/telegraf that referenced this pull request Feb 14, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mongodb feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gather raw metrics in MongoDB input
3 participants