Init passenger plugin #522
Conversation
| @@ -46,6 +46,7 @@ github.com/wvanbergen/kafka 1a8639a45164fcc245d5c7b4bd3ccfbd1a0ffbf3 | |||
| github.com/wvanbergen/kazoo-go 0f768712ae6f76454f987c3356177e138df258f8 | |||
| golang.org/x/crypto 3760e016850398b85094c4c99e955b8c3dea5711 | |||
| golang.org/x/net 99ca920b6037ef77af8a11297150f7f0d8f4ef80 | |||
| golang.org/x/text cf4986612c83df6c55578ba198316d1684a9a287 | |||
There was a problem hiding this comment.
This package is need to parse the XML with a a charset reader. The XML output has an attribute encoding=ISO88591 and I cannot simply parse it with xml.Unmarshal because go lag complains about it like this:
xml: encoding "iso8859-1" declared but Decoder.CharsetReader is nil
However, If I simply remove that attribute from XML then it works just fine. I'm not sure if we should just stripped out that attribute to remove this dependency
There was a problem hiding this comment.
no problem, thanks for adding it to Godeps
|
@sparrc I added the doc, and unit test. Also I added some comment in the code so that you can review |
| "get_wait_list_size": sg.Get_wait_list_size, | ||
| "capacity_used": sg.Capacity_used, | ||
| } | ||
| acc.AddFields("passenger", fields, tags) |
There was a problem hiding this comment.
Should this have a different name? maybe passenger_supergroup?
There was a problem hiding this comment.
Yes, I used passenger_supergroup, map them directly to the xml so user can guess the metric easily.
|
lgtm, thanks @kureikain, is this ready to merge? |
Gather metric by parsing XMLoutput of `passenger-status` utility. More information of this utility: https://www.phusionpassenger.com/library/admin/apache/overall_status_report.html
|
Yes, I rebased it with current master. |
Need unit test and document. Will add later