Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graylog Input X-Requested-By added. #5011

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Graylog Input X-Requested-By added. #5011

merged 1 commit into from
Nov 29, 2018

Conversation

gurayops
Copy link
Contributor

@gurayops gurayops commented Nov 20, 2018 •
edited by glinton
Loading

X-Requested-By is needed by Graylog in order to respond API requests. It adds URL's hostname as requested-by parameter.

Required for all PRs:

  • [ x ] Signed CLA.
  • [ x ] Associated README.md updated.
  • [ x ] Has appropriate unit tests.

Resolves #5010

@gurayops
Graylog Input X-Requested-By added.
4715c07 
X-Requested-By is needed by Graylog in order to respond API requests. It adds URL's hostname as requested-by parameter.
glinton
glinton approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it appears graylog isn't verifying the value of that field, so this should work fine.

@glinton glinton added the fix pr to fix corresponding bug label Nov 20, 2018
@danielnelson
Copy link
Contributor

Even though the contents of the header don't really matter, I think we should use Telegraf. This seems more in line with the intended header value, here are a couple examples they are using:

@danielnelson danielnelson added this to the 1.9.1 milestone Nov 29, 2018
@danielnelson
Copy link
Contributor

I'll switch the name post merge.

@danielnelson danielnelson merged commit ba612b6 into influxdata:master Nov 29, 2018
danielnelson pushed a commit that referenced this pull request Nov 29, 2018
@gurayops @danielnelson
Add X-Requested-By header to graylog input (#5011)
73b15a9 
(cherry picked from commit ba612b6)
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@gurayops @otherpirate
Add X-Requested-By header to graylog input (influxdata#5011)
866be9b
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@gurayops @otherpirate
Add X-Requested-By header to graylog input (influxdata#5011)
e17b8ae
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
@gurayops
Add X-Requested-By header to graylog input (influxdata#5011)
7306e4f
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
@gurayops @bitcharmer
Add X-Requested-By header to graylog input (influxdata#5011)
7a2faee
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@gurayops
Add X-Requested-By header to graylog input (influxdata#5011)
20dc963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

Assignees
No one assigned
Labels
fix pr to fix corresponding bug
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gurayops @danielnelson @glinton