Preserve metric type when using filters in output plugins #4481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4501
Required for all PRs:
Steps to reproduce:
Using telegraf 1.7.2 with the following config to export kube-scheduler metrics:
Histograms in http://127.0.0.1:9273/metrics look like:
With the tagpass filter removed from
outputs.prometheus_client
, the output preserved the metric type:Fix
The fix is simple, just pass the metric type when recreating the filtered metric in
RunningOutput
.I tried to add a test for it but it seems
testutil.TestMetric
needs to updated to support metric type first, which seems too big to be included in this commit.