-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved 'system' inputs out as individual inputs #4406
Moved 'system' inputs out as individual inputs #4406
Conversation
090f6a0
to
078533d
Compare
078533d
to
9c50a30
Compare
plugins/inputs/ps.go
Outdated
@@ -1,4 +1,4 @@ | |||
package system | |||
package inputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you leave this file in the system package for the time being? Long term I would like to split it out to the required plugins as well as splitting the interface up, but we should do that after moving the files to reduce the size of the conflict window.
plugins/inputs/mock_PS.go
Outdated
@@ -1,4 +1,4 @@ | |||
package system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave in system package for now.
It was mentioned in #4400 that the |
This is mostly a code organization change. From a users point of view the only change is that the README files for the plugins have been moved to a different location. For example, with the - /plugins/inputs/system/DISK_README.md
+ /plugins/inputs/disk/README.md There isn't any effect on the configuration file or on plugin availability, and the |
Required for all PRs:
This is in response to a comment made in #4290. Associated
docs
update here.I wasn't sure whether to separate
net
andnetstat
. After looking them over, it seemed like they're intended to fulfill the same purpose for different platforms, and so would remain as parts of the same package.Ultimately, I based that decision off of reading the following in the
net
README: