Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow metrics to be unserializable in influx.Reader #4047

Merged
merged 2 commits into from
Apr 19, 2018

Conversation

danielnelson
Copy link
Contributor

@danielnelson danielnelson commented Apr 19, 2018

Metrics that are unserializable will be logged at debug level, but the
rest of the batch will be sent. Unserializable metrics can occur during
normal operation such as if you remove all fields from a metric or the
metric cannot fit within the line size limit.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Metrics that are unserializable will be logged at debug level, but the
rest of the batch will be sent.  Unserializable metrics can occur during
normal operation such as if you remove all fields from a metric or the
metric cannot fit within the line size limit.
@danielnelson danielnelson added the fix pr to fix corresponding bug label Apr 19, 2018
@danielnelson danielnelson added this to the 1.6.1 milestone Apr 19, 2018
@danielnelson danielnelson merged commit 29b37e6 into master Apr 19, 2018
@danielnelson danielnelson deleted the fix-no-fields-error branch April 19, 2018 23:24
danielnelson added a commit that referenced this pull request Apr 19, 2018
Metrics that are unserializable will be logged at debug level, but the
rest of the batch will be sent.  Unserializable metrics can occur during
normal operation such as if you remove all fields from a metric or the
metric cannot fit within the line size limit.

(cherry picked from commit 29b37e6)
maxunt pushed a commit that referenced this pull request Jun 26, 2018
Metrics that are unserializable will be logged at debug level, but the
rest of the batch will be sent.  Unserializable metrics can occur during
normal operation such as if you remove all fields from a metric or the
metric cannot fit within the line size limit.
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
Metrics that are unserializable will be logged at debug level, but the
rest of the batch will be sent.  Unserializable metrics can occur during
normal operation such as if you remove all fields from a metric or the
metric cannot fit within the line size limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant