Fix make test-ci run #4002
Merged
Fix make test-ci run #4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 10, 2018 17:13
The codebased contained one go vet error, it's fixed in this commit.
A space is needed between -short and the path for finding the test files
…file was in error The output would contain '\n' newline characters. Thus failing the if statement. The quotes around the string fix this. Example error: /bin/sh line 0: [: plugins/inputs/amqp_consumer/amqp_consumer.go: binary operator expected
|
Thank you! |
codesmith14
pushed a commit
to signalfx/telegraf
that referenced
this pull request
Apr 17, 2018
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found three errors in the
make test-cirun. Each commit has more information.Worst thing; circle-ci wasn't running the actual tests. Just look at a couple of the previous pr's circle-ci builds.
Required for all PRs: