Linux_Wireless Plugin #3650
Closed
Linux_Wireless Plugin #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 9, 2018 11:47
Gather basic stats on linux-based wireless interfaces.
glinton
suggested changes
Sep 4, 2018
| myLines := strings.Split(string(table), "\n") | ||
| // split on '|' and trim the spaces | ||
| h1 := strings.Split(myLines[0], "|") | ||
| h2 := strings.Split(myLines[1], "|") |
There was a problem hiding this comment.
Check that length of h2 is at least the same length as h1 (and greater than 2) so the loop on 104 and other length-assumption references don't panic.
There was a problem hiding this comment.
Fixed and return proper error.
added 2 commits
September 4, 2018 14:55
Resolved all comments from PR review.
Resolved per CI
glinton
approved these changes
Sep 4, 2018
|
Closing in favor of a new mac/linux combined plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gather basic stats on linux-based wireless interfaces.
Required for all PRs: