Remove AWS credential check from cloudwatch output #3583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is reported to not work with IAM Instance Profiles, and we do not want to make any calls that would require additional permissions.
danielnelson
added
area/aws
danielnelson
added a commit
that referenced
this pull request
Dec 14, 2017
This method is reported to not work with IAM Instance Profiles, and we do not want to make any calls that would require additional permissions. (cherry picked from commit 5b40173)
adamchainz
added a commit
to adamchainz/telegraf
that referenced
this pull request
Dec 14, 2017
Re-add the check removed in influxdata#3583, but this time using the right API call that doesn't require any additional permissions. I tested this by running telegraf locally with my personal credentials, and also running `$ aws sts get-caller-identity` on an EC2 instance that had an IAM Role/instance profile with zero permissions.
3 tasks
aromeyer
pushed a commit
to aromeyer/telegraf
that referenced
this pull request
May 19, 2018
This method is reported to not work with IAM Instance Profiles, and we do not want to make any calls that would require additional permissions.
codesmith14
pushed a commit
to signalfx/telegraf
that referenced
this pull request
Jun 19, 2018
This method is reported to not work with IAM Instance Profiles, and we do not want to make any calls that would require additional permissions. (cherry picked from commit 5b40173)
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
This method is reported to not work with IAM Instance Profiles, and we do not want to make any calls that would require additional permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is reported to not work with IAM Instance Profiles, and we
do not want to make any calls that would require additional permissions.
closes #3474
Required for all PRs:
Associated README.md updated.