-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update net response #3455
Update net response #3455
Conversation
…result_type. Deprecating result_type as a field value in favor of result_text as a tag value. Adding a field value called result_code which is an int in the fields. Updating tests to reflect changes. Adding new tests to test other sections of the code. Updating the README.me file to reflect the changes.
@danielnelson Is there any word on when this will be released ? We are waiting on the release to push it out into our estate. |
We could add the |
This would be great for Prometheus users. |
I followed this pull request up with some minor changes to match style with http_response and dns_query plugins: fa04e53 |
Deprecating result_type as a field value in favor of result_text as a tag value.
Adding a field value called result_code which is an int in the fields.
Updating tests to reflect changes.
Adding new tests to test other sections of the code.
Updating the README.me file to reflect the changes.
Required for all PRs: