move field result_type to be a tag #3451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt and moved the current result_type string value to a tag. Fixing go linting issues. Updating tests to reflect the changes. Updating README.md to reflect the changes.
…s written out as result_value_1 as it conflicts with the tag. Updating README.md and tests to reflect the changes
3 tasks
|
rejected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the net_response plugin to move the result_type field to a tag. This will allow it so be used for filtering via the string values.
Replacing the field with value called success which has an int of 0 or 1 based on the result of the test.
Updating linting for go rules.
Updating README.md and tests to reflect the changes made.
Required for all PRs: