Fix Graphite boolean serialization test's non-deterministic behavior #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I fixed this earlier today before I saw your PR, thank you though :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to using map in test data generation, precise order fields in generated metric, and consequentially in serialised data, is undetermined. Thus Graphite plugin boolean serialisation tests may or may not fail, seemingly randomly.
There seems to be a PR in testify (stretchr/testify#491) that addresses asserting for equality of two slices disregarding order of items, which would help here. Until it's merged, a working solution would be to just sort both slices.
README.md and unit tests are not applicable