update nsq input plugin to be compatible with latest version 1.0.0-co… #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this still work with nsq version <1.0? |
|
nope - how do you want to handle that ? just a version flag default to latest perhaps? |
|
Maybe we can autodetect? We could do an optimistic parse, try to parse in latest format then fallback to old format. |
|
This should work. The tests are a bit sloppy but they work- didn't want to make them interdependent and also complicated. Parses new version and then if the version string is empty reverts to the old. |
|
any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info: #3147
Required for all PRs: