Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix amqp output block on write if disconnected #2727

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Fix amqp output block on write if disconnected #2727

merged 1 commit into from
Apr 27, 2017

Conversation

danielnelson
Copy link
Contributor

@danielnelson danielnelson commented Apr 27, 2017 •
edited
Loading

Outputs must never block on write, or it will hang all outputs and eventually inputs as well.

fixes #2603

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

@danielnelson danielnelson added this to the 1.3.0 milestone Apr 27, 2017
@danielnelson danielnelson merged commit 5fe5c46 into master Apr 27, 2017
@danielnelson danielnelson deleted the fix-amqp-timeout branch April 27, 2017 18:10
vlamug pushed a commit to vlamug/telegraf that referenced this pull request May 30, 2017
@danielnelson
Fix amqp output block on write if disconnected (influxdata#2727)
bfd6575 
fixes influxdata#2603
jeichorn pushed a commit to jeichorn/telegraf that referenced this pull request Jul 24, 2017
@danielnelson @jeichorn
Fix amqp output block on write if disconnected (influxdata#2727)
823323d 
fixes influxdata#2603
maxunt pushed a commit that referenced this pull request Jun 26, 2018
@danielnelson
Fix amqp output block on write if disconnected (#2727)
dcd6936 
fixes #2603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

AMQP output with timeout state affecting the data sent from telegraf to influxdb
2 participants
@danielnelson @121watts