Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs): Add rate-limiting infrastructure #16258

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Dec 4, 2024

Summary

This PR adds the basic infrastructure to add rate-limiting to output plugins. Currently, the only rate-limiting scheme supported is a fixed-size in fixed-time-window scheme. Furthermore, a serializer is provided that iteratively adds metrics to the serialized content. Both implementations might need to be extended in the future based on demand.

Checklist

  • No AI generated code was used in this PR

Related issues

related to #14802

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 4, 2024
@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Dec 4, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Dec 4, 2024

@DStrand1 DStrand1 assigned srebhan and unassigned DStrand1 Dec 6, 2024
@srebhan srebhan merged commit be2d5ef into influxdata:master Dec 6, 2024
27 checks passed
@srebhan srebhan deleted the ratelimiter branch December 6, 2024 10:23
@github-actions github-actions bot added this to the v1.33.0 milestone Dec 6, 2024
justinwwhuang pushed a commit to justinwwhuang/telegraf_fork that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants