Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common.socket): Make sure the scanner buffer matches the read-buffer size #16111

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 30, 2024

Summary

The current socket implementation allows to specify a read-buffer-size used when receiving data. However, when splitting the received message, the scanner currently uses the default scanner buffer size of 64KiB.

This PR makes sure the scanner buffer matches the read-buffer-size if the latter is larger than the default and adds a unit-test for the socket listener.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16082

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 30, 2024
@srebhan srebhan self-assigned this Oct 30, 2024
@srebhan srebhan added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Oct 30, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 31, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Oct 31, 2024
@DStrand1 DStrand1 merged commit 42fe362 into influxdata:master Oct 31, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.3 milestone Oct 31, 2024
s-r-engineer pushed a commit to s-r-engineer/telegraf that referenced this pull request Nov 11, 2024
srebhan added a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inputs.socket_listener] Metrics size limitations
2 participants