Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.ntpq): Avoid panic on empty lines and make sure -p is present #16110

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 30, 2024

Summary

This PR avoids scanning empty lines as this causes a panic in processLine. Furthermore, we need to make sure the command always contains the -p option to get a sensible output from the ntpq command.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16090

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 30, 2024
@srebhan srebhan self-assigned this Oct 30, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 4, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Nov 4, 2024
@DStrand1 DStrand1 merged commit 115df09 into influxdata:master Nov 4, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.3 milestone Nov 4, 2024
s-r-engineer pushed a commit to s-r-engineer/telegraf that referenced this pull request Nov 11, 2024
srebhan added a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ntpq input plugin: panicked: runtime error: index out of range [0] with length 0
2 participants