[Instrumental] Underscore metric name output #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end of write cycle so we don't hold open idle connections, which has the benefit of mostly removing the chance of getting hopelessly connection lost
…into telegraf master
…ed ident & auth handshake
correct URL from instrumental fork to origin and put the change in the correct part of the file
Connection Loss Improvement
Underscore metric names
|
you need to run |
|
@sparrc It is done! |
…different section.
| // replace invalid components of metric name with underscore | ||
| clean_metric := MetricNameReplacer.ReplaceAllString(metric, "_") | ||
|
|
||
| if !ValueIncludesBadChar.MatchString(value) { |
There was a problem hiding this comment.
do we still need to be checking this? how would it ever be true if we already replaced the bad characters above?
There was a problem hiding this comment.
The above cleans up the metric name, this line rejects bad values. If someone sends a name with bad characters, we just turn them to underscores, but if someone sends a bad value, we simply drop it.
I think the bad value that triggered this change was a time (as in HH:MM).
|
Thanks @sparrc ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the metrics emitted by various input plugins include illegal metric names for Instrumental, and this does a more thorough job of massaging those metrics into something usable.
Required for all PRs:
README.md updated (if adding a new plugin)