fix(inputs.bind): Convert counters to uint64 #16015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
fix
srebhan
force-pushed
the
bind_issue_15866
branch
from
1c7a50b to
5c11819
Compare
|
not able to download package. is it included on v1.32.1 [2024-10-07] ? |
|
@rumanmaharjan I retriggered building of the packages. Please note, those packages will be deleted after 3 days IIRC so it would be good if you could at least download the package before it is removed again... |
srebhan
added
the
ready for final review
Co-authored-by: Dane Strandboge <[email protected]>
srebhan
force-pushed
the
bind_issue_15866
branch
from
9ec4b85 to
64d4f16
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
DStrand1
approved these changes
Oct 30, 2024
srebhan
added a commit
that referenced
this pull request
Nov 18, 2024
(cherry picked from commit 9c8196f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The bind implementation of the XML v3 endpoint reports counters as unsigned integers through XML. However, the current implementation of the plugin tries to convert those numbers to signed integers which fails for large values of counters leading to a parsing error as shown in the related issue.
This PR changes the internal representation of the counters to unsigned integers for the XML v3 implementation. The PR also adds a
report_counters_as_intto keep the current, backward-compatible behavior of reporting those counters as signed integer fields. To avoid type conflicts and keep backward-compatibility the default behavior is to continue reporting those counters as integers.However, users should change the setting to
falseas soon as possible to avoid parsing errors!Checklist
Related issues
resolves #15866