Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.influxdb_v2_listener): Fix concurrent read/write dict #15982

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix(inputs.influxdb_v2_listener): Fix concurrent read/write dict #15982

merged 1 commit into from
Oct 7, 2024

Conversation

LarsStegman
Copy link
Contributor

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15952

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 4, 2024
DStrand1
DStrand1 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@DStrand1 DStrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since the CI issue is not related to these changes

@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 7, 2024
@LarsStegman LarsStegman force-pushed the fix/influxdb2listener-race branch from e12f342 to e44c461 Compare October 7, 2024 11:21
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 7, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @LarsStegman!

@srebhan srebhan merged commit a9a214e into influxdata:master Oct 7, 2024
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.32.1 milestone Oct 7, 2024
@LarsStegman
Copy link
Contributor Author

Hehe, well my crashing Pods caught it.

srebhan pushed a commit that referenced this pull request Oct 7, 2024
@LarsStegman @srebhan
fix(inputs.influxdb_v2_listener): Fix concurrent read/write dict (#15982
f35d2b4 
)

(cherry picked from commit a9a214e)
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@LarsStegman @asaharn
fix(inputs.influxdb_v2_listener): Fix concurrent read/write dict (inf…
04344b1 
…luxdata#15982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.32.1
Development

Successfully merging this pull request may close these issues.

Concurrent map read write in inputs.influxdb_v2_listener
3 participants
@LarsStegman @srebhan @DStrand1