-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(outputs.influxdb_v2): Add rate limit implementation #15742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srebhan - this is a great piece of work. Clearly this needs to be broken up into a variety of PRs to make reviewing easier, however, it accomplishes the goal nicely. I love that you were able to make the size + period config option work.
From the performance side, this nicely appears to have no affect on other existing use cases or if it no set.
I would have you consider working with support to have someone there test this out as well.
Thanks @powersj for your review. I'll adapt the spec then to reflect the possibility to set byte-based rate limits. I'll also break down the PR as it includes at least
Thanks again for the review! |
32ba732
to
4173207
Compare
1896438
to
aa5c7ee
Compare
aa5c7ee
to
c30cc4a
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! Glad to see this landed for next release 😄
Summary
This PR adds the ability to limit the output rate to InfluxDBv2 instances. Currently only a fixed window rate-limit for the amount of uncompressed data is supported.
Checklist
Related issues
resolves #14802