Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump github.com/go-ldap/ldap/v3 from 3.4.6 to 3.4.8 #15557

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 24, 2024

Bumps github.com/go-ldap/ldap/v3 from 3.4.6 to 3.4.8.

Release notes

Sourced from github.com/go-ldap/ldap/v3's releases.

v3.4.8

What's Changed

In the previous release, we have prematurely marked the function Start as deprecated, assuming that the available DialOpts fulfill all use cases. Thanks to @​dornimaug's hint in #507 we now know that this is not the case, especially when using custom contexts with DialContext, NewConn and Start. The function will be retained, and we apologize for any inconvenience! We will retain the functionality for the entire life cycle of the major version.

Full Changelog: go-ldap/ldap@v3.4.7...v3.4.8

v.3.4.7

What's new

What's Changed

New Contributors

Full Changelog: go-ldap/ldap@v3.4.6...v3.4.7

Commits
  • 06d50d1 Revert #499: Mark public Start function as deprecated (#508)
  • 2260012 fix: Replace DER with ASN1 BER encoding when parsing distinguishedNames (#505)
  • 9c14185 feat: Add tests to parseDN (fuzzing, roundtrip ...) (#504)
  • 4ca7b8e Update golang.org/x/crypto (#502)
  • 191cca8 Revert "fix: Limit maximum BER packet length in FuzzParseDN to 6553… (#500)
  • ff74b2c feat: Refactor ParseDN function to fix resource usage and invalid parsings ...
  • f09ee91 chore: add comment to Start function to inform about possible instability w...
  • 450e034 Update README to include new features and implemented RFCs
  • 87d782b Refactor the context handling with receiving an ldap response in searchAsync(...
  • d13d063 fix: mark functions as deprecated with doc comment (#491)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/go-ldap/ldap/v3](https://github.com/go-ldap/ldap) from 3.4.6 to 3.4.8.
- [Release notes](https://github.com/go-ldap/ldap/releases)
- [Commits](go-ldap/ldap@v3.4.6...v3.4.8)

---
updated-dependencies:
- dependency-name: github.com/go-ldap/ldap/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 24, 2024
@telegraf-tiger telegraf-tiger bot added the chore label Jun 24, 2024
@powersj
Copy link
Contributor

powersj commented Jun 25, 2024

I attempted to switch to the new functions away from the deprecated functions, but this seems to have caused tests to fail. Will need to look if I am missing something in terms of options.

@telegraf-tiger
Copy link
Contributor

@powersj
Copy link
Contributor

powersj commented Jun 25, 2024

Read for review, please check that I got the scheme updates correct. It seems the new call requires the scheme to be included.

Copy link
Member

@DStrand1 DStrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@DStrand1 DStrand1 removed their assignment Jun 25, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks @powersj!

@srebhan srebhan merged commit 95a17d9 into master Jun 25, 2024
28 checks passed
@srebhan srebhan deleted the dependabot/go_modules/github.com/go-ldap/ldap/v3-3.4.8 branch June 25, 2024 22:12
@github-actions github-actions bot added this to the v1.31.1 milestone Jun 25, 2024
srebhan pushed a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants