-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.systemd_units): Support user scoped units (#12053) #15458
feat(inputs.systemd_units): Support user scoped units (#12053) #15458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @pegaz! I do have some comments in the code. Furthermore, the new option needs to be added to the sample.conf
file! Also do not forget to run make docs
...
@pegaz looks like you did push some updates, other than the open README question is this ready for another review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @pegaz! I have some more minor comments/suggestions...
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -1.66 % for linux amd64 (new size: 239.6 MB, nightly size 243.7 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
Summary
Systemctl allows to monitor both system- and user-scoped units while
systemd_units
plugin currently supports only system units. PR aims to solve this limitation.Checklist
Related issues
resolves #12053