feat(inputs.sqlserver): Introduce user specified ID parameter for ADD logins

[Jan747]

Summary

If an Azure VM has more than one user assigned identiy, the authentication with the Azure SQL DB does not work.

Another method to get a token has been introduced for this and a new parameter to select an identy.

Checklist

• No AI generated code was used in this PR

Related issues

resolves #15404

[telegraf-tiger]

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

[powersj]

Thanks for the PR! I appreciate you taking the time to put this up.

I have added some comments. The only big one is what to call the option. You will also need to run make docs, or update the sqlserver README.md as well to ensure it has the new config option in the example. make docs does this for you.

[powersj]

Also need you to sign the CLA please.

[Jan747]

Hello @powersj thank you very much for your comments and tips.

I improved the PR. Please have another look on it.

[powersj]

!signed-cla

[powersj]

!signed-cla

[powersj]

@Jan747 - Thank you very much for the updates and signing the CLA. I pushed an update to ensure the linter and doc tests pass. Can you confirm you have been able to use your proposed fix and it resolves your issue?

[powersj]

@Jan747,

I need to land this early this week so we can make v1.31.0, can you confirm the PR artifacts were able to resolve your issue and you are happy with my updates?

Thanks again!

[Jan747]

Hello @powersj sorry for the late response. I wasn't able to get the version running. Docker image gave error that entrypoint.sh is missing. So I can't say if the error is now fixed or not.

[powersj]

Docker image gave error that entrypoint.sh is missing

Ah, if you share you how you are trying to build a docker image we might be able to help. Our official images use https://github.com/influxdata/influxdata-docker/tree/master/telegraf

[macxs]

I can confirm this build is working.
@Jan747 @powersj Thank you!

The error message from before is gone now and logs are clean.

...
2024-06-13T08:23:20Z I! Starting Telegraf 1.31.0-c549b29c brought to you by InfluxData the makers of InfluxDB
...
2024-06-13T08:23:20Z I! [inputs.sqlserver] Config: database_type: AzureSQLDB , query_version:0 , azuredb: false
2024-06-13T08:23:20Z I! [inputs.sqlserver] Config: Effective Queries: []string{"AzureSQLDBOsWaitstats", "AzureSQLDBResourceStats", "AzureSQLDBWaitStats", "AzureSQLDBDatabaseIO", "AzureSQLDBResourceGovernance", "AzureSQLDBPerformanceCounters"}

[powersj]

@Jan747 - can you rebase on master and resolve the one conflict? Then we can get this landed.

[Jan747]

@macxs thank you very much for testing.

@powersj confilct is solved. Anything else what I have todo ? And thank you very much again.

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 1.60 % for linux amd64 (new size: 243.5 MB, nightly size 239.7 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

[srebhan]

Thanks for your contribution @Jan747!