Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.influxdb_v2_listener): Support Secret for token #15407

Merged
merged 3 commits into from
May 31, 2024
Merged

feat(inputs.influxdb_v2_listener): Support Secret for token #15407

merged 3 commits into from
May 31, 2024

Conversation

LarsStegman
Copy link
Contributor

Summary

It should be possible to use a secret as the token source.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15406

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 27, 2024
srebhan
srebhan previously approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @LarsStegman! Only two small comments in the code. Furthermore, please add a "Secret-store support" section to the README similar to this one...

plugins/inputs/influxdb_v2_listener/influxdb_v2_listener.go Outdated Show resolved Hide resolved
plugins/inputs/influxdb_v2_listener/influxdb_v2_listener.go Outdated Show resolved Hide resolved
@srebhan srebhan dismissed their stale review May 28, 2024 15:17

Didn't mean to approve...

srebhan
srebhan reviewed May 28, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @LarsStegman! Only two small comments in the code. Furthermore, please add a "Secret-store support" section to the README similar to this one...

@srebhan srebhan self-assigned this May 28, 2024
@powersj powersj mentioned this pull request May 29, 2024
Closed
@LarsStegman LarsStegman requested a review from srebhan May 30, 2024 12:55
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LarsStegman and sorry for me taking so long to re-review!

@srebhan srebhan added area/influxdb ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. plugin/secretstores labels May 31, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan May 31, 2024
@powersj powersj merged commit d42e407 into influxdata:master May 31, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone May 31, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 10, 2024
Merged
@LarsStegman LarsStegman deleted the feat/influxdb_v2_listener-token-secret branch September 16, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

Assignees

@powersj powersj

@DStrand1 DStrand1

Labels
area/influxdb feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.

feat(inputs.influxdb_v2_listener): Support secret for token
4 participants
@LarsStegman @powersj @srebhan @DStrand1