Ping windows #1532
Merged
Ping windows #1532
+426
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // So find a line contain 3 numbers except reply lines | ||
| var stats, aproxs []string = nil, nil | ||
| err := errors.New("Fatal error processing ping output") | ||
| stat := regexp.MustCompile("=\\W*(\\d+)\\D*=\\W*(\\d+)\\D*=\\W*(\\d+)") |
There was a problem hiding this comment.
rather than double-escaping everything, you should make these raw strings, like:
`=\W*(\d+)\D*=\W*(\d+)\D*=\W*(\d+)`
|
thanks @marianob85, looks good just a couple of comments and I can get it merged this fixes #1433 |
|
Changes are made. Also rewrite little error handling. In case that no data was received (100% lost ), exit status from ping command is !=0 so there was not nice error on stderr. |
aurrelhebert
pushed a commit
to aurrelhebert/telegraf
that referenced
this pull request
Aug 9, 2016
* Ping for windows * En ping output * Code format * Code review * Default timeout * Fix problem with std error when no data received ( exit status = 1 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping for windows