-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.lustre2): Add eviction_count field #15044
Conversation
1a1ddfd
to
c06b74d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Ah I missed the lint issues:
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Adds support for https://review.whamcloud.com/c/fs/lustre-release/+/40528.
I'll rebase after #15042 is merged.
NOTE: according to https://wiki.lustre.org/Lustre_Monitoring_and_Statistics_Guide#Reading_/proc_vs_lctl it is technically safer to use
lctl get_param *.*.eviction_count
than parsing files in sysfs/procfs. In this MR I am simply following the existing convention for the plugin. Perhaps in the future we should switch to usinglctl get_param
for maximum portability. Tests would require mocking theexec.Command
output, as is done for other plugins.