Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.win_wmi): Add support for remote queries #14973

Merged
merged 1 commit into from
Mar 20, 2024
Merged

feat(inputs.win_wmi): Add support for remote queries #14973

merged 1 commit into from
Mar 20, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Mar 12, 2024 •
edited
Loading

Summary

This PR adds support to query remote hosts via WMI if a host (and credentials) are specified.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14942

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Mar 12, 2024
@srebhan srebhan added area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 12, 2024
@srebhan srebhan changed the title feat(inputs_win_wmi): Add support for remote queries feat(inputs.win_wmi): Add support for remote queries Mar 12, 2024
@srebhan srebhan mentioned this pull request Mar 12, 2024
Closed
@srebhan srebhan self-assigned this Mar 12, 2024
@srebhan srebhan marked this pull request as ready for review March 12, 2024 20:13
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 13, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Mar 13, 2024
powersj
powersj approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on the config, otherwise +1

plugins/inputs/win_wmi/README.md
## Configuration

```toml @sample.conf
# Input plugin to query Windows Management Instrumentation
# This plugin ONLY supports Windows
[[inputs.win_wmi]]
## Hostname or IP for remote connections, by default the local machine is queried
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of wonder if this should be more explicit and say "for local machines leave blank"?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's documented on the comments in the sample .conf file isn't it so i would think OK as is.

@powersj powersj removed their assignment Mar 13, 2024
@powersj powersj assigned srebhan and unassigned DStrand1 Mar 20, 2024
@powersj
Copy link
Contributor

powersj commented Mar 20, 2024

@srebhan reassigning this to you, didn't realize Dane had approved it. You can either update the readme with the one comment or land as-is. Thanks!

@powersj powersj merged commit f8905b2 into influxdata:master Mar 20, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Mar 20, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shockogit shockogit shockogit left review comments

@DStrand1 DStrand1 DStrand1 approved these changes

@powersj powersj powersj approved these changes

Assignees

@srebhan srebhan

Labels
area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.

Remote host WMI collection capabilty in the win_wmi plugin
4 participants
@srebhan @powersj @shockogit @DStrand1