-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.temp): Fix regression in metric formats #14649
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
approved these changes
Jan 30, 2024
It would be nice if the release of this fix can be expedited. |
powersj
pushed a commit
that referenced
this pull request
Jan 31, 2024
(cherry picked from commit 043ae3e)
hhiroshell
pushed a commit
to hhiroshell/telegraf
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fix
pr to fix corresponding bug
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #14575 introduces a regression for the default
v2
metric format. Additionally, a subtle difference for alarm data was discovered inv1
metrics. This has gone unnoticed due to incorrect test-data.This PR adds a unit-test for the test-data using the reference implementations of previous versions that are known-good in producing
v1
andv2
metrics. The PR furthermore, corrects the test-data and fixes the introduced regressions in bothv1
andv2
metric format.Checklist
Related issues
resolves #14646