Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.temp): Fix regression in metric formats #14649

Merged
merged 9 commits into from
Jan 30, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jan 30, 2024

Summary

PR #14575 introduces a regression for the default v2 metric format. Additionally, a subtle difference for alarm data was discovered in v1 metrics. This has gone unnoticed due to incorrect test-data.

This PR adds a unit-test for the test-data using the reference implementations of previous versions that are known-good in producing v1 and v2 metrics. The PR furthermore, corrects the test-data and fixes the introduced regressions in both v1 and v2 metric format.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14646

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 30, 2024
@powersj powersj merged commit 043ae3e into influxdata:master Jan 30, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.29.4 milestone Jan 30, 2024
@Xyaren
Copy link

Xyaren commented Jan 31, 2024

It would be nice if the release of this fix can be expedited.

powersj pushed a commit that referenced this pull request Jan 31, 2024
hhiroshell pushed a commit to hhiroshell/telegraf that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temp input changed metrics after update
3 participants