Move exec WaitGroup from Exec instance level to Gather function level. #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -156,8 +152,6 @@ func gatherWithTimeout( | |||
| acc *accumulator, | |||
| timeout time.Duration, | |||
| ) { | |||
There was a problem hiding this comment.
This function is no longer gatherWithTimeout as the timeout argument isn't used anywhere.
There was a problem hiding this comment.
Didn't mean for the last commit to end up in the pull request.
| @@ -1,3 +1,7 @@ | |||
| ### Bugfixes | |||
|
|
|||
| - [#1463](https://github.com/influxdata/telegraf/issues/1463): Shared WaitGroup in Exec plugin | |||
There was a problem hiding this comment.
this should go in the 1.0 bugfixes section
There was a problem hiding this comment.
this should go in the 1.0 bugfixes section
Why? this "bug" only happens if you run a modified version of telegraf.
allen13
force-pushed
the
master
branch
2 times, most recently
from
3a0cc4d to
d14c8a7
Compare
|
please rebase and out "closes #1463" in your commit message, and then I'll merge |
…. If Gather is run concurently the shared WaitGroup variable never finishes.
|
CHANGELOG.md conflicts resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
This pull-request addresses #1463: Shared WaitGroup in Exec plugin Bug