Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common.kafka): Correctly set gssapi username/password #14522

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jan 2, 2024

Summary

The username password settings were destroyed before the gssapi config could set them.

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #14514

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 4, 2024
@powersj powersj marked this pull request as ready for review January 4, 2024 13:38
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jan 4, 2024

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @powersj! This is a tricky one triggered by the reuse of username and password in line 61/62...

@srebhan srebhan merged commit 12095b2 into influxdata:master Jan 5, 2024
28 checks passed
@github-actions github-actions bot added this to the v1.29.2 milestone Jan 5, 2024
powersj added a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kafka fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output Kafka is missing important parameter when using Kerberos
2 participants