Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(inputs.ldap): Correct plugin name in sample config #14446

Merged
merged 2 commits into from
Dec 13, 2023
Merged

docs(inputs.ldap): Correct plugin name in sample config #14446

merged 2 commits into from
Dec 13, 2023

Conversation

tiny-pangolin
Copy link
Contributor

@tiny-pangolin tiny-pangolin commented Dec 13, 2023 •
edited by srebhan
Loading

Summary

Fixes bug with ldap configuration

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14445

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@powersj powersj changed the title Fixed plugin name in docs docs(inputs.ldap): Correct plugin name in sample config Dec 13, 2023
powersj
powersj approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 13, 2023
@tiny-pangolin
Copy link
Contributor Author

happy to help and thanks for the speedy review.
I'm assuming I don't need to do anything else and one of the maintainers will merge this?

@powersj
Copy link
Contributor

powersj commented Dec 13, 2023

I'm assuming I don't need to do anything else and one of the maintainers will merge this?

Correct! Even though the PR is small, we like both of us to sign off on PRs.

srebhan
srebhan approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and correcting this @tiny6996!

@srebhan srebhan added docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 13, 2023
@srebhan srebhan merged commit 235f055 into influxdata:master Dec 13, 2023
5 checks passed
@github-actions github-actions bot added this to the v1.29.1 milestone Dec 13, 2023
powersj pushed a commit that referenced this pull request Dec 13, 2023
@tiny-pangolin @powersj
docs(inputs.ldap): Correct plugin name in sample config (#14446)
db85bf7 
(cherry picked from commit 235f055)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.29.1
Development

Successfully merging this pull request may close these issues.

LDAP docs show openldap as the input in example
3 participants
@tiny-pangolin @powersj @srebhan