Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.bigquery): Correct use of auto-detected project ID #14416

Merged

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Dec 8, 2023

Summary

The project config isn't a required field anymore since #14086, but telegraf did not use the auto-detected project ID, this PR fixes that.

The client now also identifies telegraf as the user agent.

Checklist

  • No AI generated code was used in this PR

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Dec 8, 2023
@srebhan srebhan changed the title fix(outputs.bigquery): Correctly use auto-detected project ID. fix(outputs.bigquery): Correct use of auto-detected project ID Dec 8, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Dec 8, 2023

@Hipska Hipska requested a review from srebhan December 8, 2023 14:24
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hipska for the fix!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 11, 2023
@powersj powersj merged commit fe6e5d8 into influxdata:master Dec 11, 2023
4 checks passed
@github-actions github-actions bot added this to the v1.29.0 milestone Dec 11, 2023
@Hipska Hipska deleted the fix/outputs/bigquery/detect_project_id branch December 11, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants