-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.sflow): Add default source tag #14112
feat(inputs.sflow): Add default source tag #14112
Conversation
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
@Hipska while I love the PR, the issue is that you double the cardinality (at least for InfluxDB) users with this change. Can you please add an option to switch between the existing tag and the new |
I did follow METRIC_FORMAT_CHANGES doc, it is not considered to be unsafe (whose need such an option). |
While adding a tag is not specifically listed as "unsafe" it is listed as "be careful with
|
@Hipska same question here -do you want to make it a doc change to suggest using "source" or close this? |
Well, if the idea is to deprecate this plugin, then its best to just close this PR I guess.. |
Required for all PRs
Related to #8011 and #4413
Add the source tag to standardise the sflow input.