-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(serializers): Add CloudEvents serializer #13224
feat(serializers): Add CloudEvents serializer #13224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Can I suggest tossing your batch-metrics expected.json output into a JSON Schema validator along with the cloudevents schema. I noticed that the timedev
claims it must match RFC 3339 (e.g. 2018-04-05T17:31:00Z
)
Otherwise I think this is nearly good to go. Let me know what you think about the time one and I can give this a more complete review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 thank you for researching the timestamp.
Needs an update to resolve a conflict in go.mod. Feel free to merge once fixed.
cc32f8c
to
201dc96
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
resolves #10170
This PR adds a serializer to convert Telegraf metrics into the CloudEvents JSON format.